home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 455825759

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2405#issuecomment-455825759 https://api.github.com/repos/pydata/xarray/issues/2405 455825759 MDEyOklzc3VlQ29tbWVudDQ1NTgyNTc1OQ== 1217238 2019-01-20T00:06:21Z 2019-01-20T00:06:21Z MEMBER

I think this function mostly makes sense, but we would want to drop the stuff for scalar variables.

Unfortunately I don't know a good way to fix this stuff short of auditing a lot of code manually -- this is a hazard of data model changes. On the plus side, I've also started to do some of this for the explicit index refactor.

One thing that might turn up a few bugs is to try adding such a variable to the create_test_data() helper function which gets used in lots of places.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  357808970
Powered by Datasette · Queries took 0.706ms · About: xarray-datasette