issue_comments

Table actions

3 rows where issue = 357808970 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 3 ✖

issue 1

  • WIP: don't create indexes on multidimensional dimensions · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
455794328 https://github.com/pydata/xarray/pull/2405#issuecomment-455794328 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQ1NTc5NDMyOA== rabernat 1197350 2019-01-19T16:28:53Z 2019-01-19T16:28:53Z MEMBER

I had some spare time and started working on this again. I'm scared of how much internal refactoring it requires. For example, this function

https://github.com/pydata/xarray/blob/385b36cdd34431b4f6f14aad1f222f989e7e2de2/xarray/core/dataset.py#L92-L113

just doesn't make sense any more if dimensions are not guaranteed to be one-dimensional.

I've never touched this part of the code base before. I have no idea how many places there are that make such an assumption.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970
420014715 https://github.com/pydata/xarray/pull/2405#issuecomment-420014715 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQyMDAxNDcxNQ== rabernat 1197350 2018-09-10T18:31:43Z 2018-09-10T18:31:43Z MEMBER

With 68f170c there are basically no failing tests in the original test suite. I will now work on adding more tests along the lines outlined by @shoyer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970
419295930 https://github.com/pydata/xarray/pull/2405#issuecomment-419295930 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQxOTI5NTkzMA== rabernat 1197350 2018-09-07T01:56:44Z 2018-09-07T01:56:44Z MEMBER

Seeking suggestions about what else needs to be tested here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);