home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 455794328

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2405#issuecomment-455794328 https://api.github.com/repos/pydata/xarray/issues/2405 455794328 MDEyOklzc3VlQ29tbWVudDQ1NTc5NDMyOA== 1197350 2019-01-19T16:28:53Z 2019-01-19T16:28:53Z MEMBER

I had some spare time and started working on this again. I'm scared of how much internal refactoring it requires. For example, this function

https://github.com/pydata/xarray/blob/385b36cdd34431b4f6f14aad1f222f989e7e2de2/xarray/core/dataset.py#L92-L113

just doesn't make sense any more if dimensions are not guaranteed to be one-dimensional.

I've never touched this part of the code base before. I have no idea how many places there are that make such an assumption.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  357808970
Powered by Datasette · Queries took 77.028ms · About: xarray-datasette