issue_comments

Table actions

7 rows where issue = 356698348 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • shoyer · 7 ✖

issue 1

  • implement Gradient · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
423017107 https://github.com/pydata/xarray/pull/2398#issuecomment-423017107 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMzAxNzEwNw== shoyer 1217238 2018-09-20T02:14:25Z 2018-09-20T02:14:25Z MEMBER

@rabernat let me know if this makes sense to you / if you agree.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
422980788 https://github.com/pydata/xarray/pull/2398#issuecomment-422980788 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMjk4MDc4OA== shoyer 1217238 2018-09-19T22:33:58Z 2018-09-19T22:33:58Z MEMBER

I'm going to merge this after the Appveyor tests pass, unless there are any further objections.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
422949281 https://github.com/pydata/xarray/pull/2398#issuecomment-422949281 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMjk0OTI4MQ== shoyer 1217238 2018-09-19T20:36:15Z 2018-09-19T20:36:15Z MEMBER

We should definitely mention specialized tools like xgcm as alternatives in the docstring for these xarray methods.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
422949121 https://github.com/pydata/xarray/pull/2398#issuecomment-422949121 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMjk0OTEyMQ== shoyer 1217238 2018-09-19T20:35:43Z 2018-09-19T20:35:43Z MEMBER

@rabernat my inclination would be to draw the line at regular grids (with or without periodic boundary conditions), which are pretty commonly encountered in data analysis for any continuous physical systems. We would leave non-regular cases like staggered-grids to add-ons like xgcm -- these grids tend to be more application/PDE specific.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
422940673 https://github.com/pydata/xarray/pull/2398#issuecomment-422940673 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMjk0MDY3Mw== shoyer 1217238 2018-09-19T20:07:35Z 2018-09-19T20:07:35Z MEMBER

@shoyer, have you seen da.pad?

Yes, pad solves the hard part of periodic boundary conditions -- we should just need to do a bit of book-keeping on the xarray side.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
422863296 https://github.com/pydata/xarray/pull/2398#issuecomment-422863296 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQyMjg2MzI5Ng== shoyer 1217238 2018-09-19T16:11:51Z 2018-09-19T16:11:51Z MEMBER

Speaking of derivatives on the globe, we might want to include an option for periodic boundary conditions (and possibly for other functions like interp as well). But we can save that for another PR :).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348
418530033 https://github.com/pydata/xarray/pull/2398#issuecomment-418530033 https://api.github.com/repos/pydata/xarray/issues/2398 MDEyOklzc3VlQ29tbWVudDQxODUzMDAzMw== shoyer 1217238 2018-09-04T21:51:44Z 2018-09-04T21:51:44Z MEMBER

I think this will be very welcome functionality!

I wonder if we should consider calling this xarray.differentiate instead of xarray.gradient. I think the NumPy function is poorly named for differentiating along a single axis at once.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Gradient 356698348

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);