issue_comments

Table actions

2 rows where issue = 354324342 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 2 ✖

issue 1

  • Adding data kwarg to copy to create new objects with same structure as original · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
422535898 https://github.com/pydata/xarray/pull/2384#issuecomment-422535898 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMjUzNTg5OA== max-sixty 5635139 2018-09-18T20:14:04Z 2018-09-18T20:14:04Z MEMBER

Thank you v much @jsignell ! Both for the excellent code and for bearing with the changes!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
421171706 https://github.com/pydata/xarray/pull/2384#issuecomment-421171706 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMTE3MTcwNg== max-sixty 5635139 2018-09-13T22:22:44Z 2018-09-13T22:22:44Z MEMBER

Sorry I'm late to the party here. @jsignell thank you for the PR!

Pandas has something similar: the ._shallow_copy method, which accepts optional data to replace the current data.

Ambitious suggestion: given that we already create shallow copies when copying, could data become an optional arg to copy? I realize it's may be a little surprising to change all the data and still call it a copy, but there's precedent.

Less ambitious: I'd vote to have this as a method. I'm generally partial to methods given their discoverability and namespaces-without-cost. I think the context is clear. OTOH there is precedent with ones_like et al.

Naming: I'd vote labelled_like > structured_like, but not strongly

That said, given my timing, I'd understand if we go forward as-is

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);