issue_comments

Table actions

2 rows where issue = 342180429 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fujiisoup · 2 ✖

issue 1

  • Making xarray math lazy · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
406128252 https://github.com/pydata/xarray/issues/2298#issuecomment-406128252 https://api.github.com/repos/pydata/xarray/issues/2298 MDEyOklzc3VlQ29tbWVudDQwNjEyODI1Mg== fujiisoup 6815844 2018-07-19T01:47:36Z 2018-07-19T01:47:36Z MEMBER

Thanks, @shoyer

we have enough related functionality (e.g., for lazy and explicit indexing)

Agreed. Actually, it sounds very fun to code the lazy arithmetics.

Ideally, this logic would live outside xarray.

Yes, I concerned about this. We have discussed to support more kinds of array-likes (e.g. dask, sparse, cupy) in #1938, and I thought the lazy array can be (ideally) one of them.

But in practice, it should take a long time to realize the any-array-like support and it might be a good idea to natively support the lazy mathematics for now. If we are heading to any-array-like support, I think that the implementation of the lazy array should be as isolated from xarray core logic as possible so that we can move smoothly to the any-array-like support in the future.

Therefore, personally, I'd like to see this lazy math by implementing a lazy array. The API I thought of is .to_lazy() which converts the backend to the lazy array, as similar to that .chunk() converts the backend to dask array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Making xarray math lazy 342180429
405817290 https://github.com/pydata/xarray/issues/2298#issuecomment-405817290 https://api.github.com/repos/pydata/xarray/issues/2298 MDEyOklzc3VlQ29tbWVudDQwNTgxNzI5MA== fujiisoup 6815844 2018-07-18T05:53:18Z 2018-07-18T05:53:18Z MEMBER

This sounds interesting. I am curious what the practical difference from dask is. Does it mean some maths are lazy by default (without any external library)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Making xarray math lazy 342180429

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);