issue_comments

Table actions

5 rows where issue = 336371511 and user = 8699967 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • snowman2 · 5 ✖

issue 1

  • Add automatic chunking to open_rasterio · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
514713407 https://github.com/pydata/xarray/pull/2255#issuecomment-514713407 https://api.github.com/repos/pydata/xarray/issues/2255 MDEyOklzc3VlQ29tbWVudDUxNDcxMzQwNw== snowman2 8699967 2019-07-24T16:53:50Z 2019-07-24T16:53:50Z CONTRIBUTOR

Put another way: why don't we put all the logic in rioxarray and make rioxarray an optional dependency of xarray to open rio files?

That is an option. All of the logic has already been moved over.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add automatic chunking to open_rasterio 336371511
514688429 https://github.com/pydata/xarray/pull/2255#issuecomment-514688429 https://api.github.com/repos/pydata/xarray/issues/2255 MDEyOklzc3VlQ29tbWVudDUxNDY4ODQyOQ== snowman2 8699967 2019-07-24T15:46:36Z 2019-07-24T15:46:36Z CONTRIBUTOR

I'm curious, are there features in rioxarray that could be pushed upstream?

Depends on what the xarray maintainers would like to add. I would definitely like to see the open_rasterio function in rioxarray absorbed back into xarray. Things have just been really slow moving with the other PRs/issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add automatic chunking to open_rasterio 336371511
514685330 https://github.com/pydata/xarray/pull/2255#issuecomment-514685330 https://api.github.com/repos/pydata/xarray/issues/2255 MDEyOklzc3VlQ29tbWVudDUxNDY4NTMzMA== snowman2 8699967 2019-07-24T15:38:53Z 2019-07-24T15:39:53Z CONTRIBUTOR

I've abandoned this PR. If anyone has time to pick it up, that would be welcome.

I appreciate you staring this! Based on this PR, I added the feature into rioxarray here: https://github.com/corteva/rioxarray/pull/31 (released in version 0.0.9). (Example usage can be seen here.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add automatic chunking to open_rasterio 336371511
514628738 https://github.com/pydata/xarray/pull/2255#issuecomment-514628738 https://api.github.com/repos/pydata/xarray/issues/2255 MDEyOklzc3VlQ29tbWVudDUxNDYyODczOA== snowman2 8699967 2019-07-24T13:19:47Z 2019-07-24T13:55:35Z CONTRIBUTOR

How to create tiled TIFF files in the tests

One thing I would like to note is that the automatic chunking would be useful if the raster is tiled or not. I tested out a raster that was not tiled, but it still had chunks. This is due to the raster being written in stripes. So, I would recommend removing the restriction to only tiled rasters.

Also, to create a tiled raster: ```python import rasterio import numpy from affine import Affine

with rasterio.open( "tiled.tif", "w", driver="GTiff", count=2, width=1024, height=1024, crs="+init=epsg:4326", transform=Affine(0.0083333333, 0.0, -180.00416666665, 0.0, -0.0083333333, 75.00416666665), dtype=rasterio.float32, tiled=True, blockxsize=512, blockysize=512, ) as rds: rds.write((numpy.random.rand(2, 1024, 1024)*10).astype(numpy.float32)) ```

Looks like they have this option in the tests:

python open_kwargs=dict( tiled=True, blockxsize=512, blockysize=512 ) with create_tmp_geotiff(nx=1024, ny=1024, nz=2, open_kwargs=open_kwargs) as (tmp_file, expected): ....

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add automatic chunking to open_rasterio 336371511
514626195 https://github.com/pydata/xarray/pull/2255#issuecomment-514626195 https://api.github.com/repos/pydata/xarray/issues/2255 MDEyOklzc3VlQ29tbWVudDUxNDYyNjE5NQ== snowman2 8699967 2019-07-24T13:12:47Z 2019-07-24T13:27:41Z CONTRIBUTOR

The right way to merge different dtypes and block shapes in the tiff file. Currently I'm assuming that they're uniform

I have yet to run into a raster that varies dtypes and block shapes across bands. Most of the time, they are single band rasters. And if they are not, they have had the same dtype and block shape. So, I think your assumption is a good one for most use cases.

Also, only a single dtype is allowed currently: https://github.com/pydata/xarray/blob/1d7bcbdc75b6d556c04e2c7d7a042e4379e15303/xarray/backends/rasterio_.py#L39-L40

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add automatic chunking to open_rasterio 336371511

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);