issue_comments

with #4697 and the fact that this seems to have been included in rioxarray: should we close this?

Put another way: why don't we put all the logic in rioxarray and make rioxarray an optional dependency of xarray to open rio files?

That is an option. All of the logic has already been moved over.

I'm curious, are there features in rioxarray that could be pushed upstream?

Depends on what the xarray maintainers would like to add. I would definitely like to see the open_rasterio function in rioxarray absorbed back into xarray. Things have just been really slow moving with the other PRs/issues.

Put another way: why don't we put all the logic in rioxarray and make rioxarray an optional dependency of xarray to open rio files?

I'm curious, are there features in rioxarray that could be pushed upstream?

Depends on what the xarray maintainers would like to add. I would definitely like to see the open_rasterio function in rioxarray absorbed back into xarray. Things have just been really slow moving with the other PRs/issues.

I'm glad to hear it! I'm curious, are there features in rioxarray that could be pushed upstream?

On Wed, Jul 24, 2019 at 8:39 AM Alan D. Snow notifications@github.com wrote:

I've abandoned this PR. If anyone has time to pick it up, that would be welcome.

I appreciate you staring this! Based on this PR, I added the feature into rioxarray here: corteva/rioxarray#31 https://github.com/corteva/rioxarray/pull/31 (released in version 0.0.9).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2255?email_source=notifications&email_token=AACKZTHDF5BOUXGTTZ55M3DQBBZRJA5CNFSM4FHJIU5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WXTEQ#issuecomment-514685330, or mute the thread https://github.com/notifications/unsubscribe-auth/AACKZTDNYY2CK4WV4FBASGTQBBZRJANCNFSM4FHJIU5A .

I've abandoned this PR. If anyone has time to pick it up, that would be welcome.

I appreciate you staring this! Based on this PR, I added the feature into rioxarray here: https://github.com/corteva/rioxarray/pull/31 (released in version 0.0.9). (Example usage can be seen here.)

I've abandoned this PR. If anyone has time to pick it up, that would be welcome. I think that it would have positive impact.

How to create tiled TIFF files in the tests

One thing I would like to note is that the automatic chunking would be useful if the raster is tiled or not. I tested out a raster that was not tiled, but it still had chunks. This is due to the raster being written in stripes. So, I would recommend removing the restriction to only tiled rasters.

Also, to create a tiled raster: ```python import rasterio import numpy from affine import Affine

with rasterio.open( "tiled.tif", "w", driver="GTiff", count=2, width=1024, height=1024, crs="+init=epsg:4326", transform=Affine(0.0083333333, 0.0, -180.00416666665, 0.0, -0.0083333333, 75.00416666665), dtype=rasterio.float32, tiled=True, blockxsize=512, blockysize=512, ) as rds: rds.write((numpy.random.rand(2, 1024, 1024)*10).astype(numpy.float32)) ```

Looks like they have this option in the tests:

python open_kwargs=dict( tiled=True, blockxsize=512, blockysize=512 ) with create_tmp_geotiff(nx=1024, ny=1024, nz=2, open_kwargs=open_kwargs) as (tmp_file, expected): ....

The right way to merge different dtypes and block shapes in the tiff file. Currently I'm assuming that they're uniform

I have yet to run into a raster that varies dtypes and block shapes across bands. Most of the time, they are single band rasters. And if they are not, they have had the same dtype and block shape. So, I think your assumption is a good one for most use cases.

Also, only a single dtype is allowed currently: https://github.com/pydata/xarray/blob/1d7bcbdc75b6d556c04e2c7d7a042e4379e15303/xarray/backends/rasterio_.py#L39-L40

```python import os if not os.path.exists('myfile.tif'): import requests response = requests.get('https://oin-hotosm.s3.amazonaws.com/5abae68e65bd8f00110f3e42/0/5abae68e65bd8f00110f3e43.tif') with open('myfile.tif', 'wb') as f: f.write(response.content)

import dask dask.config.set({'array.chunk-size': '1MiB'})

import xarray as xr ds = xr.open_rasterio('myfile.tif', chunks=True) # this only reads metadata to start

ds.chunks ((1, 1, 1), (1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 136), (1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 995)) ```

Also depends on https://github.com/dask/dask/pull/3679 . Without that PR it will use values that are similar, but don't precisely align with 1024.

Oh, I should point out that the image has tiles of size (512, 512)