issue_comments

Table actions

4 rows where issue = 322849322 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Using `DataArray.where()` with a DataArray as the condition drops the name · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
613313818 https://github.com/pydata/xarray/issues/2129#issuecomment-613313818 https://api.github.com/repos/pydata/xarray/issues/2129 MDEyOklzc3VlQ29tbWVudDYxMzMxMzgxOA== jacklovell 4849151 2020-04-14T08:54:33Z 2020-04-14T08:54:33Z NONE

This bug appears to have been fixed, as of Xarray 0.15.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Using `DataArray.where()` with a DataArray as the condition drops the name 322849322
613307425 https://github.com/pydata/xarray/issues/2129#issuecomment-613307425 https://api.github.com/repos/pydata/xarray/issues/2129 MDEyOklzc3VlQ29tbWVudDYxMzMwNzQyNQ== stale[bot] 26384082 2020-04-14T08:42:12Z 2020-04-14T08:42:12Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Using `DataArray.where()` with a DataArray as the condition drops the name 322849322
389079066 https://github.com/pydata/xarray/issues/2129#issuecomment-389079066 https://api.github.com/repos/pydata/xarray/issues/2129 MDEyOklzc3VlQ29tbWVudDM4OTA3OTA2Ng== jacklovell 4849151 2018-05-15T08:00:31Z 2018-05-15T08:00:31Z NONE

Yes, I think it makes sense to couple it with keep_attrs=True. One could question whether the name should be considered separate to the attributes (and therefore have an additional keyword argument for keeping the name), but I think in most cases it makes sense to keep the name if you're already keeping the attributes, and to drop the name if you're dropping the attributes.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Using `DataArray.where()` with a DataArray as the condition drops the name 322849322
388917199 https://github.com/pydata/xarray/issues/2129#issuecomment-388917199 https://api.github.com/repos/pydata/xarray/issues/2129 MDEyOklzc3VlQ29tbWVudDM4ODkxNzE5OQ== shoyer 1217238 2018-05-14T18:30:19Z 2018-05-14T18:30:19Z MEMBER

Indeed, we should have some sort of logic to indicate that the name from the original DataArray should be preserved.

Under the hood, DataArray.where uses xarray.apply_ufunc. So maybe this should be coupled with keep_attrs=True in xarray.apply_ufunc()?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Using `DataArray.where()` with a DataArray as the condition drops the name 322849322

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);