issue_comments: 389079066

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2129#issuecomment-389079066 https://api.github.com/repos/pydata/xarray/issues/2129 389079066 MDEyOklzc3VlQ29tbWVudDM4OTA3OTA2Ng== 4849151 2018-05-15T08:00:31Z 2018-05-15T08:00:31Z NONE

Yes, I think it makes sense to couple it with keep_attrs=True. One could question whether the name should be considered separate to the attributes (and therefore have an additional keyword argument for keeping the name), but I think in most cases it makes sense to keep the name if you're already keeping the attributes, and to drop the name if you're dropping the attributes.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   322849322