issue_comments

Table actions

4 rows where issue = 322191051 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Remove 'out' from docstrings for wrapped numpy unary functions · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
388855301 https://github.com/pydata/xarray/pull/2117#issuecomment-388855301 https://api.github.com/repos/pydata/xarray/issues/2117 MDEyOklzc3VlQ29tbWVudDM4ODg1NTMwMQ== dcherian 2448579 2018-05-14T15:18:21Z 2018-05-14T15:18:21Z MEMBER

OK It'll take me some time to get to that. Closing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove 'out' from docstrings for wrapped numpy unary functions 322191051
388534266 https://github.com/pydata/xarray/pull/2117#issuecomment-388534266 https://api.github.com/repos/pydata/xarray/issues/2117 MDEyOklzc3VlQ29tbWVudDM4ODUzNDI2Ng== shoyer 1217238 2018-05-12T06:33:52Z 2018-05-12T06:33:52Z MEMBER

The cleaner solution here would be to try to get rid of _method_wrapper by writing explicit methods/functions implemented with apply_ufunc: https://github.com/pydata/xarray/blob/a52540505f606bd7619536d82d43f19f2cbe58b5/xarray/core/ops.py#L34-L40

This is the strategy suggested in this TODO note: https://github.com/pydata/xarray/blob/a52540505f606bd7619536d82d43f19f2cbe58b5/xarray/core/ops.py#L3-L5

This is a bit more verbose but it would be much more obvious what's going on.

clip would probably be the place to start, since it's the only one with an invalid out argument. You could just copy the relevant parts of the docstring from NumPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove 'out' from docstrings for wrapped numpy unary functions 322191051
388392655 https://github.com/pydata/xarray/pull/2117#issuecomment-388392655 https://api.github.com/repos/pydata/xarray/issues/2117 MDEyOklzc3VlQ29tbWVudDM4ODM5MjY1NQ== dcherian 2448579 2018-05-11T15:09:32Z 2018-05-11T15:09:32Z MEMBER

Ugh, serves me right for submitting PRs late at night. Thanks, @fmaussion. I'll wait for feedback on the approach before fixing it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove 'out' from docstrings for wrapped numpy unary functions 322191051
388353109 https://github.com/pydata/xarray/pull/2117#issuecomment-388353109 https://api.github.com/repos/pydata/xarray/issues/2117 MDEyOklzc3VlQ29tbWVudDM4ODM1MzEwOQ== fmaussion 10050469 2018-05-11T12:45:42Z 2018-05-11T12:45:42Z MEMBER

Thanks!

I wonder is this is the best way to do this but I don't have a better idea either. Surely @shoyer can weight in.

Anyways, this doesn't pass through the tests because sometimes __doc__ is None. Also I think we need some kind of test for this. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove 'out' from docstrings for wrapped numpy unary functions 322191051

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);