issue_comments: 388534266

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2117#issuecomment-388534266 https://api.github.com/repos/pydata/xarray/issues/2117 388534266 MDEyOklzc3VlQ29tbWVudDM4ODUzNDI2Ng== 1217238 2018-05-12T06:33:52Z 2018-05-12T06:33:52Z MEMBER

The cleaner solution here would be to try to get rid of _method_wrapper by writing explicit methods/functions implemented with apply_ufunc: https://github.com/pydata/xarray/blob/a52540505f606bd7619536d82d43f19f2cbe58b5/xarray/core/ops.py#L34-L40

This is the strategy suggested in this TODO note: https://github.com/pydata/xarray/blob/a52540505f606bd7619536d82d43f19f2cbe58b5/xarray/core/ops.py#L3-L5

This is a bit more verbose but it would be much more obvious what's going on.

clip would probably be the place to start, since it's the only one with an invalid out argument. You could just copy the relevant parts of the docstring from NumPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   322191051