issue_comments

Table actions

3 rows where issue = 318574154 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • xarray.dot is now based on da.einsum · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
386744384 https://github.com/pydata/xarray/pull/2089#issuecomment-386744384 https://api.github.com/repos/pydata/xarray/issues/2089 MDEyOklzc3VlQ29tbWVudDM4Njc0NDM4NA== shoyer 1217238 2018-05-04T21:51:01Z 2018-05-04T21:51:01Z MEMBER

thanks @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.dot is now based on da.einsum 318574154
386729292 https://github.com/pydata/xarray/pull/2089#issuecomment-386729292 https://api.github.com/repos/pydata/xarray/issues/2089 MDEyOklzc3VlQ29tbWVudDM4NjcyOTI5Mg== crusaderky 6213168 2018-05-04T20:43:18Z 2018-05-04T20:43:18Z MEMBER

@shoyer integrated your suggestion

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.dot is now based on da.einsum 318574154
385835874 https://github.com/pydata/xarray/pull/2089#issuecomment-385835874 https://api.github.com/repos/pydata/xarray/issues/2089 MDEyOklzc3VlQ29tbWVudDM4NTgzNTg3NA== shoyer 1217238 2018-05-02T01:12:05Z 2018-05-02T01:12:05Z MEMBER

It looks like the dot tests are now failing on test_dot because they don't find the right version of dask -- which makes sense because dask hasn't made the 0.17.3 release yet.

Let's wait until that happens (hopefully very soon: https://github.com/dask/dask/issues/3452) before merging this. But we should also add a conditional version check for test_dot with dask. Something like: if LooseVersion(dask.__version__) < LooseVersion('0.17.3'): pytest.skip("needs dask.array.einsum")

(The appveyor failures should be fixed if you merge in master.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.dot is now based on da.einsum 318574154

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);