issue_comments: 385835874

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2089#issuecomment-385835874 https://api.github.com/repos/pydata/xarray/issues/2089 385835874 MDEyOklzc3VlQ29tbWVudDM4NTgzNTg3NA== 1217238 2018-05-02T01:12:05Z 2018-05-02T01:12:05Z MEMBER

It looks like the dot tests are now failing on test_dot because they don't find the right version of dask -- which makes sense because dask hasn't made the 0.17.3 release yet.

Let's wait until that happens (hopefully very soon: https://github.com/dask/dask/issues/3452) before merging this. But we should also add a conditional version check for test_dot with dask. Something like: if LooseVersion(dask.__version__) < LooseVersion('0.17.3'): pytest.skip("needs dask.array.einsum")

(The appveyor failures should be fixed if you merge in master.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   318574154