issue_comments

Table actions

4 rows where issue = 317362786 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • apply_ufunc should include variable names in error messages · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
524966912 https://github.com/pydata/xarray/issues/2078#issuecomment-524966912 https://api.github.com/repos/pydata/xarray/issues/2078 MDEyOklzc3VlQ29tbWVudDUyNDk2NjkxMg== rdrussotto 13667821 2019-08-26T18:10:23Z 2019-08-26T18:10:23Z CONTRIBUTOR

The clarification I mentioned has now been committed, with other edits to the error message suggested by @dcherian. Obviously it doesn't make sense to close the issue yet, in case someone wants to take on the tougher task of adding the variable name to the message.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should include variable names in error messages 317362786
511230920 https://github.com/pydata/xarray/issues/2078#issuecomment-511230920 https://api.github.com/repos/pydata/xarray/issues/2078 MDEyOklzc3VlQ29tbWVudDUxMTIzMDkyMA== shoyer 1217238 2019-07-14T19:59:34Z 2019-07-14T19:59:34Z MEMBER

Including the variable name in the error message would require separately specifying the variable name as an input argument to "broadcast_compat_data" and "apply_variable_ufunc" and refactoring the code that calls these functions, which seems like adding too much complexity just for an error message.

I agree that this is more complex, but it still might be worth doing. Good error messages are important!

We do internally in a few other places already.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should include variable names in error messages 317362786
511156832 https://github.com/pydata/xarray/issues/2078#issuecomment-511156832 https://api.github.com/repos/pydata/xarray/issues/2078 MDEyOklzc3VlQ29tbWVudDUxMTE1NjgzMg== rdrussotto 13667821 2019-07-13T22:00:06Z 2019-07-13T22:00:27Z CONTRIBUTOR

This is much harder than I thought. The function that throws this error doesn't have access to the variable name data, since it takes Variable objects as input which don't contain name information. apply_ufunc and its dependent functions are designed to take in a Dataset, DataArray, Variable, GroupBy or other object that might contain one or many variables, strip out the individual variable objects and run the computation on each of them. Including the variable name in the error message would require separately specifying the variable name as an input argument to "broadcast_compat_data" and "apply_variable_ufunc" and refactoring the code that calls these functions, which seems like adding too much complexity just for an error message. For now I think I'm going to change "the input variable" to "an input variable", which is at least a more accurate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should include variable names in error messages 317362786
511151541 https://github.com/pydata/xarray/issues/2078#issuecomment-511151541 https://api.github.com/repos/pydata/xarray/issues/2078 MDEyOklzc3VlQ29tbWVudDUxMTE1MTU0MQ== rdrussotto 13667821 2019-07-13T20:30:20Z 2019-07-13T20:30:20Z CONTRIBUTOR

I am working on this. The error listed here is thrown by the "broadcast_compat_data" function, which is called by "apply_variable_ufunc", which is in turn called by "apply_ufunc". There are other similar error messages that can happen where a variable name would also be helpful. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should include variable names in error messages 317362786

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);