home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 511156832

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2078#issuecomment-511156832 https://api.github.com/repos/pydata/xarray/issues/2078 511156832 MDEyOklzc3VlQ29tbWVudDUxMTE1NjgzMg== 13667821 2019-07-13T22:00:06Z 2019-07-13T22:00:27Z CONTRIBUTOR

This is much harder than I thought. The function that throws this error doesn't have access to the variable name data, since it takes Variable objects as input which don't contain name information. apply_ufunc and its dependent functions are designed to take in a Dataset, DataArray, Variable, GroupBy or other object that might contain one or many variables, strip out the individual variable objects and run the computation on each of them. Including the variable name in the error message would require separately specifying the variable name as an input argument to "broadcast_compat_data" and "apply_variable_ufunc" and refactoring the code that calls these functions, which seems like adding too much complexity just for an error message. For now I think I'm going to change "the input variable" to "an input variable", which is at least a more accurate.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  317362786
Powered by Datasette · Queries took 0.685ms · About: xarray-datasette