issue_comments

Table actions

2 rows where issue = 312633077 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Feature request: writing xarray list-type attributes to netCDF · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
379898944 https://github.com/pydata/xarray/issues/2044#issuecomment-379898944 https://api.github.com/repos/pydata/xarray/issues/2044 MDEyOklzc3VlQ29tbWVudDM3OTg5ODk0NA== dnowacki-usgs 13837821 2018-04-09T21:25:30Z 2018-04-09T21:25:30Z CONTRIBUTOR

Ah, nice, thanks. Glad to see it will be default behavior in the future. For kicks, I decided to try to implement it on my own. Pretty much stumbling around in the dark here, but I think I got it working. PR forthcoming.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature request: writing xarray list-type attributes to netCDF 312633077
379880131 https://github.com/pydata/xarray/issues/2044#issuecomment-379880131 https://api.github.com/repos/pydata/xarray/issues/2044 MDEyOklzc3VlQ29tbWVudDM3OTg4MDEzMQ== shoyer 1217238 2018-04-09T20:16:25Z 2018-04-09T20:16:25Z MEMBER

OK, this is a relatively new feature for netCDF4-Python (https://github.com/Unidata/netcdf4-python/pull/597), but I agree that it's one we should support in xarray. Interestingly, it looks like it will be the default behavior as of the next netCDF4-Python release (https://github.com/Unidata/netcdf4-python/issues/770).

So at this point, I suppose we could just wait. Or if you like, we could backport this behavior in xarray to also support older versions of netCDF4-Python.

The logic for writing attributes with netCDF4-Python in xarray can be found here: https://github.com/pydata/xarray/blob/master/xarray/backends/netCDF4_.py#L346=L350

and here: https://github.com/pydata/xarray/blob/master/xarray/backends/netCDF4_.py#L402=L405

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature request: writing xarray list-type attributes to netCDF 312633077

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);