issue_comments: 379880131
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/2044#issuecomment-379880131 | https://api.github.com/repos/pydata/xarray/issues/2044 | 379880131 | MDEyOklzc3VlQ29tbWVudDM3OTg4MDEzMQ== | 1217238 | 2018-04-09T20:16:25Z | 2018-04-09T20:16:25Z | MEMBER | OK, this is a relatively new feature for netCDF4-Python (https://github.com/Unidata/netcdf4-python/pull/597), but I agree that it's one we should support in xarray. Interestingly, it looks like it will be the default behavior as of the next netCDF4-Python release (https://github.com/Unidata/netcdf4-python/issues/770). So at this point, I suppose we could just wait. Or if you like, we could backport this behavior in xarray to also support older versions of netCDF4-Python. The logic for writing attributes with netCDF4-Python in xarray can be found here: https://github.com/pydata/xarray/blob/master/xarray/backends/netCDF4_.py#L346=L350 and here: https://github.com/pydata/xarray/blob/master/xarray/backends/netCDF4_.py#L402=L405 |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
312633077 |