issue_comments

Table actions

3 rows where issue = 307783090 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • dcherian · 3 ✖

issue 1

  • rolling: allow control over padding · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
876579830 https://github.com/pydata/xarray/issues/2007#issuecomment-876579830 https://api.github.com/repos/pydata/xarray/issues/2007 MDEyOklzc3VlQ29tbWVudDg3NjU3OTgzMA== dcherian 2448579 2021-07-08T16:30:06Z 2021-07-08T16:30:06Z MEMBER

Yes. I think we might want this anyway; for rolling without any padding at all.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling: allow control over padding 307783090
875980218 https://github.com/pydata/xarray/issues/2007#issuecomment-875980218 https://api.github.com/repos/pydata/xarray/issues/2007 MDEyOklzc3VlQ29tbWVudDg3NTk4MDIxOA== dcherian 2448579 2021-07-07T22:38:08Z 2021-07-07T22:38:08Z MEMBER

This should be easy now so we just need someone to try it out.

This is where the padding happens so the kwarg needs to be passed all the way down to Variable.rolling_window https://github.com/pydata/xarray/blob/67d1955cc1d6941edd12a325090da7e4d029b84c/xarray/core/variable.py#L2132

What should the API be? .rolling(..., pad_kwargs={...}) or just have .pad(...).rolling(..., pad=False) i.e. have the user pad beforehand? The only advantage to the first one AFAICT is that the user doesn't have to specify the window length (or padding length) twice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling: allow control over padding 307783090
747500929 https://github.com/pydata/xarray/issues/2007#issuecomment-747500929 https://api.github.com/repos/pydata/xarray/issues/2007 MDEyOklzc3VlQ29tbWVudDc0NzUwMDkyOQ== dcherian 2448579 2020-12-17T15:16:06Z 2020-12-17T15:16:06Z MEMBER

I think we should do pad_kwargs so that monthly.rolling(center-True, month=n_months, pad_kwargs=dict(mode="constant", constant_values=5)} is possible.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rolling: allow control over padding 307783090

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);