issue_comments

Table actions

4 rows where issue = 301888608 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 4 ✖

issue 1

  • ds.to_zarr error on creation · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
370044335 https://github.com/pydata/xarray/issues/1954#issuecomment-370044335 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0NDMzNQ== rabernat 1197350 2018-03-02T20:32:59Z 2018-03-02T20:32:59Z MEMBER

I think you're right. Since zarr 2.2 is being released so soon, it's probably silly to add such a check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370042719 https://github.com/pydata/xarray/issues/1954#issuecomment-370042719 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MjcxOQ== rabernat 1197350 2018-03-02T20:26:24Z 2018-03-02T20:26:48Z MEMBER

@kaipak it would be great if you could put together a quick PR that would raise an error on importing zarr if the version is too old.

You would insert this around here: https://github.com/pydata/xarray/blob/master/xarray/backends/zarr.py#L273

The code would looks something like: ```python from distutils.version import LooseVersion ... import zarr if LooseVersion(zarr.version) < '2.2': raise NotImplementedError("Zarr version 2.2 or greater is required by xarray. " "See zarr installation instructions at http://zarr.readthedocs.io/en/stable/#installation")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370041032 https://github.com/pydata/xarray/issues/1954#issuecomment-370041032 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MTAzMg== rabernat 1197350 2018-03-02T20:19:40Z 2018-03-02T20:19:40Z MEMBER

I guess we should be raising an error if zarr is too old rather than failing in this way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370037927 https://github.com/pydata/xarray/issues/1954#issuecomment-370037927 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDAzNzkyNw== rabernat 1197350 2018-03-02T20:06:38Z 2018-03-02T20:06:38Z MEMBER

Can you show the output of xr.show_versions()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);