issue_comments

Table actions

8 rows where issue = 301888608 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • ds.to_zarr error on creation · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
370155913 https://github.com/pydata/xarray/issues/1954#issuecomment-370155913 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDE1NTkxMw== kaipak 9453271 2018-03-03T15:31:24Z 2018-03-03T15:31:24Z CONTRIBUTOR

Thanks guys, that fixed the problem.

I could do a PR for it. Even if it 2.2 is coming out so soon, it would be nice to get a clear error for users so they don't lose a bunch of cycles trying to debug. As you noted, it would be relatively easy to implement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370044335 https://github.com/pydata/xarray/issues/1954#issuecomment-370044335 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0NDMzNQ== rabernat 1197350 2018-03-02T20:32:59Z 2018-03-02T20:32:59Z MEMBER

I think you're right. Since zarr 2.2 is being released so soon, it's probably silly to add such a check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370043488 https://github.com/pydata/xarray/issues/1954#issuecomment-370043488 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MzQ4OA== jhamman 2443309 2018-03-02T20:29:49Z 2018-03-02T20:29:49Z MEMBER

Okay, this is just a little messy right now because we're ahead of zarr in their release schedule. We expect that will come out on Monday (see https://github.com/zarr-developers/zarr/issues/242).

Typically, we have stayed away from checking versions of all optional dependencies on import this may be one time that would be useful. The problem is these checks often fall out of date end up causing unnecessary clutter down the line.

To resolve this we can add a version check (as you've shown above) or we can wait until Monday. I'm also not opposed to mentioning in the documentation what minimum version we support is. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370042719 https://github.com/pydata/xarray/issues/1954#issuecomment-370042719 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MjcxOQ== rabernat 1197350 2018-03-02T20:26:24Z 2018-03-02T20:26:48Z MEMBER

@kaipak it would be great if you could put together a quick PR that would raise an error on importing zarr if the version is too old.

You would insert this around here: https://github.com/pydata/xarray/blob/master/xarray/backends/zarr.py#L273

The code would looks something like: ```python from distutils.version import LooseVersion ... import zarr if LooseVersion(zarr.version) < '2.2': raise NotImplementedError("Zarr version 2.2 or greater is required by xarray. " "See zarr installation instructions at http://zarr.readthedocs.io/en/stable/#installation")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370041032 https://github.com/pydata/xarray/issues/1954#issuecomment-370041032 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MTAzMg== rabernat 1197350 2018-03-02T20:19:40Z 2018-03-02T20:19:40Z MEMBER

I guess we should be raising an error if zarr is too old rather than failing in this way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370040272 https://github.com/pydata/xarray/issues/1954#issuecomment-370040272 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDA0MDI3Mg== shoyer 1217238 2018-03-02T20:16:32Z 2018-03-02T20:16:32Z MEMBER

We should document this more clearly, but you need zarr 2.2 (currently in release candidate stage) for use with xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370039149 https://github.com/pydata/xarray/issues/1954#issuecomment-370039149 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDAzOTE0OQ== kaipak 9453271 2018-03-02T20:11:33Z 2018-03-02T20:11:33Z CONTRIBUTOR

``` INSTALLED VERSIONS

commit: None python: 3.6.2.final.0 python-bits: 64 OS: Linux OS-release: 3.10.0-693.17.1.el7.centos.plus.x86_64 machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: en_US.UTF-8

xarray: 0.10.1 pandas: 0.20.3 numpy: 1.13.1 scipy: 0.19.1 netCDF4: 1.2.4 h5netcdf: 0.5.0 h5py: 2.7.0 Nio: None zarr: 2.1.4 bottleneck: 1.2.1 cyordereddict: None dask: 0.15.2 distributed: 1.18.1 matplotlib: 2.0.2 cartopy: None seaborn: 0.8.0 setuptools: 36.4.0 pip: 9.0.1 conda: None pytest: None IPython: 6.1.0 sphinx: None ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608
370037927 https://github.com/pydata/xarray/issues/1954#issuecomment-370037927 https://api.github.com/repos/pydata/xarray/issues/1954 MDEyOklzc3VlQ29tbWVudDM3MDAzNzkyNw== rabernat 1197350 2018-03-02T20:06:38Z 2018-03-02T20:06:38Z MEMBER

Can you show the output of xr.show_versions()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ds.to_zarr error on creation 301888608

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);