issue_comments

Table actions

4 rows where issue = 298481284 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 4 ✖

issue 1

  • Add x,y kwargs for plot.line(). · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
369467411 https://github.com/pydata/xarray/pull/1926#issuecomment-369467411 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2OTQ2NzQxMQ== dcherian 2448579 2018-03-01T04:01:59Z 2018-03-01T04:01:59Z MEMBER

Done and rebased on master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284
368760427 https://github.com/pydata/xarray/pull/1926#issuecomment-368760427 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2ODc2MDQyNw== dcherian 2448579 2018-02-27T06:20:50Z 2018-02-27T06:20:50Z MEMBER

Updated and rebased. Now these are the only options. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284
367397397 https://github.com/pydata/xarray/pull/1926#issuecomment-367397397 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2NzM5NzM5Nw== dcherian 2448579 2018-02-21T17:05:37Z 2018-02-21T17:06:13Z MEMBER

either by (i) specifying the name of the variable to the axis you want to plot it onto, or (ii) by specifying the name of the coordinate you want to use for the axis. Since (ii) is the default and only option for 1D and 2D plots until now, I just wondered if (i) is very necessary.

It does feel a little strange that if you had a DataArray with non-dimension coordinates you could make a plot without including any of the DataArray values

Good points. I'll change it so that only one of x and y can be specified.

My main thought is that this API would feel much more natural on a Dataset object, alongside a .plot.scatter() method.

It's very useful in oceanography (and meteorology) where we want to make plots of physical quantities like temperature against depth; it is much more natural to see depth on the y-axis than the x-axis. This is the original usecase @rabernat mention in #575.

The Dataset API is a more involved undertaking that I'm not confident of executing at this point.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284
367152500 https://github.com/pydata/xarray/pull/1926#issuecomment-367152500 https://api.github.com/repos/pydata/xarray/issues/1926 MDEyOklzc3VlQ29tbWVudDM2NzE1MjUwMA== dcherian 2448579 2018-02-20T23:04:59Z 2018-02-20T23:07:03Z MEMBER

@fmaussion when I added the hue argument, @shoyer suggested that we have a "fully explicit way to make these plots". In this case this would mean da.plot(x='temp', y='time', hue='lat') which seems a lot more readable than da.plot(y='coordinate', hue='lat')

It would also mean that x,y are different from hue (for hue we do specify dimension name).

@shoyer Thoughts?

EDIT:

@fmaussion Do you mean da.plot(y='time', x=None, hue='lat')?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add x,y kwargs for plot.line(). 298481284

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);