issue_comments

Table actions

4 rows where issue = 287569331 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 4 ✖

issue 1

  • fix rasterio chunking with s3 datasets · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
359892573 https://github.com/pydata/xarray/pull/1817#issuecomment-359892573 https://api.github.com/repos/pydata/xarray/issues/1817 MDEyOklzc3VlQ29tbWVudDM1OTg5MjU3Mw== rabernat 1197350 2018-01-23T18:54:24Z 2018-01-23T18:54:24Z MEMBER

@fmaussion - so sorry I accidentally deleted your tests. I was just rushing to resolve the conflicts so as not to hold up the other PRs. I hope this does not cause too much inconvenience.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix rasterio chunking with s3 datasets 287569331
359814915 https://github.com/pydata/xarray/pull/1817#issuecomment-359814915 https://api.github.com/repos/pydata/xarray/issues/1817 MDEyOklzc3VlQ29tbWVudDM1OTgxNDkxNQ== rabernat 1197350 2018-01-23T14:54:07Z 2018-01-23T14:54:07Z MEMBER

I resolved conflicts. LGTM before it gets stale again!

Is it bad form to merge my own PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix rasterio chunking with s3 datasets 287569331
357456847 https://github.com/pydata/xarray/pull/1817#issuecomment-357456847 https://api.github.com/repos/pydata/xarray/issues/1817 MDEyOklzc3VlQ29tbWVudDM1NzQ1Njg0Nw== rabernat 1197350 2018-01-13T18:41:46Z 2018-01-13T18:41:46Z MEMBER

this will mess with #1712 and #1740 quite a bit

I probably should have paid more attention to those PR's. My apologies.

Here is how I ended up refactoring the tests. I had to write a new test to catch the bug I discovered. I looked at the existing tests for guidance and saw lots of boilerplate. So rather than copying the boilerplate, I refactored it.

Let me know how I can help resolve this conflicts this may cause with the other open PRs. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix rasterio chunking with s3 datasets 287569331
357450408 https://github.com/pydata/xarray/pull/1817#issuecomment-357450408 https://api.github.com/repos/pydata/xarray/issues/1817 MDEyOklzc3VlQ29tbWVudDM1NzQ1MDQwOA== rabernat 1197350 2018-01-13T17:08:50Z 2018-01-13T17:08:50Z MEMBER

I also refactored the rasterio test suite to eliminate a lot of boilerplate dataset creation and added tests for network urls. I'm not a geotiff expert, so please let me know if I have done anything silly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix rasterio chunking with s3 datasets 287569331

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);