home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 357456847

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1817#issuecomment-357456847 https://api.github.com/repos/pydata/xarray/issues/1817 357456847 MDEyOklzc3VlQ29tbWVudDM1NzQ1Njg0Nw== 1197350 2018-01-13T18:41:46Z 2018-01-13T18:41:46Z MEMBER

this will mess with #1712 and #1740 quite a bit

I probably should have paid more attention to those PR's. My apologies.

Here is how I ended up refactoring the tests. I had to write a new test to catch the bug I discovered. I looked at the existing tests for guidance and saw lots of boilerplate. So rather than copying the boilerplate, I refactored it.

Let me know how I can help resolve this conflicts this may cause with the other open PRs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  287569331
Powered by Datasette · Queries took 0.706ms · About: xarray-datasette