issue_comments

Table actions

4 rows where issue = 282369945 and user = 12229877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • Zac-HD · 4 ✖

issue 1

  • Include units (if set) in plot labels · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
362976003 https://github.com/pydata/xarray/pull/1787#issuecomment-362976003 https://api.github.com/repos/pydata/xarray/issues/1787 MDEyOklzc3VlQ29tbWVudDM2Mjk3NjAwMw== Zac-HD 12229877 2018-02-05T04:01:16Z 2018-02-05T04:01:16Z CONTRIBUTOR

This is now far enough down my list of priorities that I'm unlikely to get to it any time soon, and (it turns out) there are also some design issues that would need to be resolved.

I therefore suggest that anyone wishing to take this on opens an issue first to clarify the scope of any such change, and then make a PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include units (if set) in plot labels 282369945
355815405 https://github.com/pydata/xarray/pull/1787#issuecomment-355815405 https://api.github.com/repos/pydata/xarray/issues/1787 MDEyOklzc3VlQ29tbWVudDM1NTgxNTQwNQ== Zac-HD 12229877 2018-01-07T11:21:25Z 2018-01-07T11:21:25Z CONTRIBUTOR
  • Including units in labels more generally sounds good to me, but I'll hold off until the general concept is approved 😉
  • I don't think there's an objectively correct way to label units, but parentheses seem to be fairly standard and least prone to misinterpretation.
  • Happy to add tests, though again I'll wait for in-principle approval. Adding a units attribute to some of the test data is easy enough!
  • units is the convention, and if this is unsatisfactory it's quite trivial to override already - I'd hold off on custom options until someone has an actual use-case for the feature.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include units (if set) in plot labels 282369945
355745453 https://github.com/pydata/xarray/pull/1787#issuecomment-355745453 https://api.github.com/repos/pydata/xarray/issues/1787 MDEyOklzc3VlQ29tbWVudDM1NTc0NTQ1Mw== Zac-HD 12229877 2018-01-06T12:59:31Z 2018-01-06T12:59:31Z CONTRIBUTOR

Ping @fmaussion for review? (the build error is Travis download trouble, not failing tests)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include units (if set) in plot labels 282369945
351963684 https://github.com/pydata/xarray/pull/1787#issuecomment-351963684 https://api.github.com/repos/pydata/xarray/issues/1787 MDEyOklzc3VlQ29tbWVudDM1MTk2MzY4NA== Zac-HD 12229877 2017-12-15T09:56:32Z 2017-12-15T22:23:59Z CONTRIBUTOR

The exact key units is required by the CF Conventions and most similar conventions, and very common in other landscape and hydrology data I work with.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include units (if set) in plot labels 282369945

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);