issue_comments: 355815405

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1787#issuecomment-355815405 https://api.github.com/repos/pydata/xarray/issues/1787 355815405 MDEyOklzc3VlQ29tbWVudDM1NTgxNTQwNQ== 12229877 2018-01-07T11:21:25Z 2018-01-07T11:21:25Z CONTRIBUTOR
  • Including units in labels more generally sounds good to me, but I'll hold off until the general concept is approved 😉
  • I don't think there's an objectively correct way to label units, but parentheses seem to be fairly standard and least prone to misinterpretation.
  • Happy to add tests, though again I'll wait for in-principle approval. Adding a units attribute to some of the test data is easy enough!
  • units is the convention, and if this is unsatisfactory it's quite trivial to override already - I'd hold off on custom options until someone has an actual use-case for the feature.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   282369945