issue_comments

Table actions

2 rows where issue = 279198672 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Fix DataArray.__dask_scheduler__ to point to dask.threaded.get · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
350109792 https://github.com/pydata/xarray/pull/1760#issuecomment-350109792 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM1MDEwOTc5Mg== shoyer 1217238 2017-12-07T22:09:20Z 2017-12-07T22:09:20Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672
350074558 https://github.com/pydata/xarray/pull/1760#issuecomment-350074558 https://api.github.com/repos/pydata/xarray/issues/1760 MDEyOklzc3VlQ29tbWVudDM1MDA3NDU1OA== shoyer 1217238 2017-12-07T19:47:44Z 2017-12-07T19:47:44Z MEMBER

Should I drop the current modifications to the .compute methods and just leave in the dask_scheduler fix?

That's probably easiest for now -- updating our mock tests to handle either calling dask.compute() or the Array.compute() method would be a little tricky.

It would be nice to add a test case that uses the default scheduler, e.g., that does a basic compute on each xarray type (Dataset, DataArray and Variable) inside a with dask.set_options(get=None) block. That would give us test coverage for __dask_scheduler__, which is currently missing.

(It would probably be better to explicitly set get explicitly in a function when computing xarray objects containing dask arrays, but that's a larger project.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix DataArray.__dask_scheduler__ to point to dask.threaded.get 279198672

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);