issue_comments: 350074558

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1760#issuecomment-350074558 https://api.github.com/repos/pydata/xarray/issues/1760 350074558 MDEyOklzc3VlQ29tbWVudDM1MDA3NDU1OA== 1217238 2017-12-07T19:47:44Z 2017-12-07T19:47:44Z MEMBER

Should I drop the current modifications to the .compute methods and just leave in the dask_scheduler fix?

That's probably easiest for now -- updating our mock tests to handle either calling dask.compute() or the Array.compute() method would be a little tricky.

It would be nice to add a test case that uses the default scheduler, e.g., that does a basic compute on each xarray type (Dataset, DataArray and Variable) inside a with dask.set_options(get=None) block. That would give us test coverage for __dask_scheduler__, which is currently missing.

(It would probably be better to explicitly set get explicitly in a function when computing xarray objects containing dask arrays, but that's a larger project.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   279198672