issue_comments

Table actions

4 rows where issue = 278325492 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fujiisoup · 4 ✖

issue 1

  • Indexing Variable objects with a mask · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
351597414 https://github.com/pydata/xarray/pull/1751#issuecomment-351597414 https://api.github.com/repos/pydata/xarray/issues/1751 MDEyOklzc3VlQ29tbWVudDM1MTU5NzQxNA== fujiisoup 6815844 2017-12-14T03:23:05Z 2017-12-14T03:23:05Z MEMBER

This looks good to me.

I think it is ready to expose _getitem_with_mask to public. As you mention in #TODO, I also think isel is the best place.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing Variable objects with a mask 278325492
351594432 https://github.com/pydata/xarray/pull/1751#issuecomment-351594432 https://api.github.com/repos/pydata/xarray/issues/1751 MDEyOklzc3VlQ29tbWVudDM1MTU5NDQzMg== fujiisoup 6815844 2017-12-14T03:00:34Z 2017-12-14T03:00:34Z MEMBER

Sorry for my late review. I will see later today.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing Variable objects with a mask 278325492
348853749 https://github.com/pydata/xarray/pull/1751#issuecomment-348853749 https://api.github.com/repos/pydata/xarray/issues/1751 MDEyOklzc3VlQ29tbWVudDM0ODg1Mzc0OQ== fujiisoup 6815844 2017-12-04T03:45:48Z 2017-12-04T03:45:48Z MEMBER

Could you add more test coverage of the first commit? It would help other developers to follow the logic.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing Variable objects with a mask 278325492
348376506 https://github.com/pydata/xarray/pull/1751#issuecomment-348376506 https://api.github.com/repos/pydata/xarray/issues/1751 MDEyOklzc3VlQ29tbWVudDM0ODM3NjUwNg== fujiisoup 6815844 2017-12-01T01:39:41Z 2017-12-01T01:39:41Z MEMBER

It is a great idea! I previously raised #1553 for multidimensional reindex, but am still thinking how could we implement it. _getitem_with_mask looks cleanest.

I will look inside the code later, but I feel this should be exposed to the public. In this case, what is the most consistent naming with the existing methods? isel_mask?

I would probably leave it as a Variable method since this is pretty low-level.

Agreed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Indexing Variable objects with a mask 278325492

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);