issue_comments: 348376506

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1751#issuecomment-348376506 https://api.github.com/repos/pydata/xarray/issues/1751 348376506 MDEyOklzc3VlQ29tbWVudDM0ODM3NjUwNg== 6815844 2017-12-01T01:39:41Z 2017-12-01T01:39:41Z MEMBER

It is a great idea! I previously raised #1553 for multidimensional reindex, but am still thinking how could we implement it. _getitem_with_mask looks cleanest.

I will look inside the code later, but I feel this should be exposed to the public. In this case, what is the most consistent naming with the existing methods? isel_mask?

I would probably leave it as a Variable method since this is pretty low-level.

Agreed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   278325492