issue_comments

Table actions

4 rows where issue = 277589143 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Fix in vectorized item assignment · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
350389750 https://github.com/pydata/xarray/pull/1746#issuecomment-350389750 https://api.github.com/repos/pydata/xarray/issues/1746 MDEyOklzc3VlQ29tbWVudDM1MDM4OTc1MA== shoyer 1217238 2017-12-08T22:37:51Z 2017-12-08T22:37:51Z MEMBER

Looks good to me. @fujiisoup please hit the big green button when you're ready!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix in vectorized item assignment 277589143
350148756 https://github.com/pydata/xarray/pull/1746#issuecomment-350148756 https://api.github.com/repos/pydata/xarray/issues/1746 MDEyOklzc3VlQ29tbWVudDM1MDE0ODc1Ng== fujiisoup 6815844 2017-12-08T01:49:53Z 2017-12-08T01:49:53Z MEMBER

@shoyer Thanks for the review.

Do we also need to update assignment for .loc, or does this already handle it?

Done.

As I commented above, coordinate validation requires an (practically) unused indexing. I am wondering the efficiency of the indexing, though __setitem__ might be less frequently used than __getitem__.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix in vectorized item assignment 277589143
349558179 https://github.com/pydata/xarray/pull/1746#issuecomment-349558179 https://api.github.com/repos/pydata/xarray/issues/1746 MDEyOklzc3VlQ29tbWVudDM0OTU1ODE3OQ== fujiisoup 6815844 2017-12-06T07:30:53Z 2017-12-06T07:30:53Z MEMBER

I will update docs as this is a backward-incompatible change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix in vectorized item assignment 277589143
347877894 https://github.com/pydata/xarray/pull/1746#issuecomment-347877894 https://api.github.com/repos/pydata/xarray/issues/1746 MDEyOklzc3VlQ29tbWVudDM0Nzg3Nzg5NA== fujiisoup 6815844 2017-11-29T14:33:27Z 2017-11-29T14:33:27Z MEMBER

Tests are failing due to #1738. I think this is ready for review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix in vectorized item assignment 277589143

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);