home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 350148756

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1746#issuecomment-350148756 https://api.github.com/repos/pydata/xarray/issues/1746 350148756 MDEyOklzc3VlQ29tbWVudDM1MDE0ODc1Ng== 6815844 2017-12-08T01:49:53Z 2017-12-08T01:49:53Z MEMBER

@shoyer Thanks for the review.

Do we also need to update assignment for .loc, or does this already handle it?

Done.

As I commented above, coordinate validation requires an (practically) unused indexing. I am wondering the efficiency of the indexing, though __setitem__ might be less frequently used than __getitem__.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  277589143
Powered by Datasette · Queries took 0.959ms · About: xarray-datasette