issue_comments

Table actions

5 rows where issue = 276131376 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Rasterio missing _FillValue in DataArray · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
447903844 https://github.com/pydata/xarray/issues/1736#issuecomment-447903844 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDQ0NzkwMzg0NA== snowman2 8699967 2018-12-17T16:19:45Z 2018-12-17T16:19:45Z CONTRIBUTOR

It would definitely be a fantastic feature to have. Some discussion happened in #2308 to discuss standardizing methods for storing data that would definitely assist with this, however it did not seem like a priority at the time. Definitely feel free to share your opinion and use cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376
447882917 https://github.com/pydata/xarray/issues/1736#issuecomment-447882917 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDQ0Nzg4MjkxNw== jsignell 4806877 2018-12-17T15:22:27Z 2018-12-17T15:22:27Z CONTRIBUTOR

Is there still interest in implementing the mask option as outlined in this issue? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376
346513920 https://github.com/pydata/xarray/issues/1736#issuecomment-346513920 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDM0NjUxMzkyMA== snowman2 8699967 2017-11-23T01:23:54Z 2017-11-23T01:24:11Z CONTRIBUTOR

One thought I had was that there could be a similar parameter to mask_and_scale added that could be just called mask so open_rasterio behaves similarly to the open_dataset api. The mask parameter can allow the user to decide if they want to convert to float to get a mask or leave it alone if they want to preserve the integer data.

I would vote for adding the _FillValue attribute as it conforms with the CF conventions and it will make the dataset work better with other software looking for this value if you write it out with to_netcdf().

Also, on a similar vein, it would be nice to break out the bands into separate variables if it is a multi-band raster. This way, each band can store it's own nodata value and metadata separately in the dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376
346427925 https://github.com/pydata/xarray/issues/1736#issuecomment-346427925 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDM0NjQyNzkyNQ== fmaussion 10050469 2017-11-22T17:56:18Z 2017-11-22T17:56:18Z MEMBER

What I'm not sure, though, is if we should rename the attribute to _FillValue or keep its name as it is. I am also not sure if we should do the automatic conversion as it is done with the netCDF backends. Quite often geotiff files store iteger types, and filling with NaNs require floats.

Right now I would tend to just parse the nodatavals attribute and leave everything else to the user.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376
346427043 https://github.com/pydata/xarray/issues/1736#issuecomment-346427043 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDM0NjQyNzA0Mw== fmaussion 10050469 2017-11-22T17:52:48Z 2017-11-22T17:52:48Z MEMBER

I agree that it would be nice to have. It seems that the corresponding rasterio attribute is nodatavals (https://github.com/mapbox/rasterio/blob/master/docs/topics/masks.rst). It shouldn't be too difficult to add to the existing attributes: https://github.com/pydata/xarray/blob/master/xarray/backends/rasterio_.py#L142

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);