issue_comments: 346513920

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1736#issuecomment-346513920 https://api.github.com/repos/pydata/xarray/issues/1736 346513920 MDEyOklzc3VlQ29tbWVudDM0NjUxMzkyMA== 8699967 2017-11-23T01:23:54Z 2017-11-23T01:24:11Z CONTRIBUTOR

One thought I had was that there could be a similar parameter to mask_and_scale added that could be just called mask so open_rasterio behaves similarly to the open_dataset api. The mask parameter can allow the user to decide if they want to convert to float to get a mask or leave it alone if they want to preserve the integer data.

I would vote for adding the _FillValue attribute as it conforms with the CF conventions and it will make the dataset work better with other software looking for this value if you write it out with to_netcdf().

Also, on a similar vein, it would be nice to break out the bands into separate variables if it is a multi-band raster. This way, each band can store it's own nodata value and metadata separately in the dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   276131376