issue_comments

Table actions

9 rows where issue = 275789502 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Rank Methods · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
352485702 https://github.com/pydata/xarray/pull/1733#issuecomment-352485702 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM1MjQ4NTcwMg== shoyer 1217238 2017-12-18T16:51:05Z 2017-12-18T16:51:05Z MEMBER

Thank you!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
350349645 https://github.com/pydata/xarray/pull/1733#issuecomment-350349645 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM1MDM0OTY0NQ== max-sixty 5635139 2017-12-08T19:23:52Z 2017-12-08T19:23:52Z MEMBER

This looks great @0x0L thanks & congrats on your first contribution!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
349106643 https://github.com/pydata/xarray/pull/1733#issuecomment-349106643 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0OTEwNjY0Mw== shoyer 1217238 2017-12-04T21:10:40Z 2017-12-04T21:10:40Z MEMBER

Should i move the implementation on Variable and use temp datasets like quantile does ?

I would be happy either way here. In some ways, yes, that would be the cleanest solution.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
349105759 https://github.com/pydata/xarray/pull/1733#issuecomment-349105759 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0OTEwNTc1OQ== 0x0L 3621629 2017-12-04T21:07:40Z 2017-12-04T21:07:40Z CONTRIBUTOR

Should i move the implementation on Variable and use temp datasets like quantile does ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
349091429 https://github.com/pydata/xarray/pull/1733#issuecomment-349091429 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0OTA5MTQyOQ== shoyer 1217238 2017-12-04T20:15:49Z 2017-12-04T20:15:49Z MEMBER

when the ranking dimension is missing from an array in the dataset, should we do nothing, or put 1s everywhere ?

Good point, maybe it needs to be slightly more complicated than apply.

Two other options are raise an error (safest) or to drop all such variables from the result. The later is similar to what we do in aggregations like sum() if an argument is non-numeric. I think this is probably the best choice: it strikes a good balance between not returning an invalid result and not raising errors so often as to be annoying.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
349088887 https://github.com/pydata/xarray/pull/1733#issuecomment-349088887 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0OTA4ODg4Nw== 0x0L 3621629 2017-12-04T20:06:41Z 2017-12-04T20:06:41Z CONTRIBUTOR

@shoyer when the ranking dimension is missing from an array in the dataset, should we do nothing, or put 1s everywhere ? None of these looks appealing or natural.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
346905769 https://github.com/pydata/xarray/pull/1733#issuecomment-346905769 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0NjkwNTc2OQ== 0x0L 3621629 2017-11-24T23:23:36Z 2017-11-24T23:23:36Z CONTRIBUTOR

Dropped support for Dataset. I don't think there's much use for it anyway.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
346713298 https://github.com/pydata/xarray/pull/1733#issuecomment-346713298 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0NjcxMzI5OA== 0x0L 3621629 2017-11-24T00:41:29Z 2017-11-24T00:41:29Z CONTRIBUTOR

@shoyer Thanks for the comment and the tips! I'll make the changes asap, hopefully this week-end

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502
346510205 https://github.com/pydata/xarray/pull/1733#issuecomment-346510205 https://api.github.com/repos/pydata/xarray/issues/1733 MDEyOklzc3VlQ29tbWVudDM0NjUxMDIwNQ== shoyer 1217238 2017-11-23T00:46:21Z 2017-11-23T00:46:21Z MEMBER

Thanks for putting this together!

Rather than using the injection stuff in ops.py (which we would like to eliminate), I would prefer to simply implement this as a method on Dataset and DataArray.

Also take a look at the use of apply_ufunc in https://github.com/pydata/xarray/pull/1640 for a straightforward example of wrapping external functions. I think that would make things easier here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rank Methods 275789502

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);