issue_comments: 346510205

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1733#issuecomment-346510205 https://api.github.com/repos/pydata/xarray/issues/1733 346510205 MDEyOklzc3VlQ29tbWVudDM0NjUxMDIwNQ== 1217238 2017-11-23T00:46:21Z 2017-11-23T00:46:21Z MEMBER

Thanks for putting this together!

Rather than using the injection stuff in ops.py (which we would like to eliminate), I would prefer to simply implement this as a method on Dataset and DataArray.

Also take a look at the use of apply_ufunc in https://github.com/pydata/xarray/pull/1640 for a straightforward example of wrapping external functions. I think that would make things easier here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   275789502