issue_comments

Table actions

7 rows where issue = 273268690 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 7 ✖

issue 1

  • Use rasterio's transform instead of homemade coordinates · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
360789654 https://github.com/pydata/xarray/pull/1712#issuecomment-360789654 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM2MDc4OTY1NA== fmaussion 10050469 2018-01-26T13:51:15Z 2018-01-26T13:51:15Z MEMBER

All green! Will try to get to the tests in the upcoming days

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
357457494 https://github.com/pydata/xarray/pull/1712#issuecomment-357457494 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM1NzQ1NzQ5NA== fmaussion 10050469 2018-01-13T18:51:23Z 2018-01-13T18:51:23Z MEMBER

Thanks for the review @shoyer ! I will wait for https://github.com/pydata/xarray/pull/1817 to be merged before going on here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
356737816 https://github.com/pydata/xarray/pull/1712#issuecomment-356737816 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM1NjczNzgxNg== fmaussion 10050469 2018-01-10T21:10:55Z 2018-01-10T21:10:55Z MEMBER

I wonder if someone from @pydata/xarray wants to have a look -- if possible I'd like to get this in before the next point release. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
355060935 https://github.com/pydata/xarray/pull/1712#issuecomment-355060935 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM1NTA2MDkzNQ== fmaussion 10050469 2018-01-03T16:44:29Z 2018-01-03T16:44:29Z MEMBER

Thanks @maaleske for having a look.

having the coordinate generation separately exposed would be nice

I agree, but this could be done in a separate PR as this needs another kind of discussion: do we want these kind of domain-specific tools in the codebase (and where?), and is Affine sufficiently used to justify this? Here we use Affine because it is a rasterio dependency, but I don't know if it is used outside of it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
351759168 https://github.com/pydata/xarray/pull/1712#issuecomment-351759168 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM1MTc1OTE2OA== fmaussion 10050469 2017-12-14T16:19:31Z 2017-12-14T16:19:31Z MEMBER

@snowman2 I added an example in the code on how to do this - can be useful for downstream libraries

@maaleske @jhamman this is ready for review / opinions. This PR still closes https://github.com/pydata/xarray/issues/1686 in a backwards compatible manner and adds a special case for irregular coordinates. I don't think that 2D coordinates happen very often (never encountered one in my work), but xarray should handle them now. The PR also makes some minor other modifications.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
348722604 https://github.com/pydata/xarray/pull/1712#issuecomment-348722604 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM0ODcyMjYwNA== fmaussion 10050469 2017-12-02T21:49:01Z 2017-12-02T21:49:01Z MEMBER

I added a parse_coordinates=True kwarg and added a check for 2D coordinates.

I proposed an implementation for the 2D case, but it feels a bit clunky. A second option would be to not parse 2D coords and raise a Warning in case of parse_coordinates=True and 2D coordinates. (I don't think that 2D coords happen very often).

Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690
343777829 https://github.com/pydata/xarray/pull/1712#issuecomment-343777829 https://api.github.com/repos/pydata/xarray/issues/1712 MDEyOklzc3VlQ29tbWVudDM0Mzc3NzgyOQ== fmaussion 10050469 2017-11-12T23:29:56Z 2017-11-12T23:29:56Z MEMBER

OK, I think this is ready for review (@shoyer or @jhamman) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use rasterio's transform instead of homemade coordinates  273268690

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);