home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 348722604

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1712#issuecomment-348722604 https://api.github.com/repos/pydata/xarray/issues/1712 348722604 MDEyOklzc3VlQ29tbWVudDM0ODcyMjYwNA== 10050469 2017-12-02T21:49:01Z 2017-12-02T21:49:01Z MEMBER

I added a parse_coordinates=True kwarg and added a check for 2D coordinates.

I proposed an implementation for the 2D case, but it feels a bit clunky. A second option would be to not parse 2D coords and raise a Warning in case of parse_coordinates=True and 2D coordinates. (I don't think that 2D coords happen very often).

Thoughts?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  273268690
Powered by Datasette · Queries took 0.704ms · About: xarray-datasette