issue_comments

Table actions

4 rows where issue = 271991268 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • ffill & bfill methods · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
343704025 https://github.com/pydata/xarray/pull/1696#issuecomment-343704025 https://api.github.com/repos/pydata/xarray/issues/1696 MDEyOklzc3VlQ29tbWVudDM0MzcwNDAyNQ== max-sixty 5635139 2017-11-12T00:14:26Z 2017-11-12T00:14:26Z MEMBER

@jhamman Perfect! I had a read through yours and it looks great, excited to get this merged. I'll close this

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ffill & bfill methods 271991268
343649431 https://github.com/pydata/xarray/pull/1696#issuecomment-343649431 https://api.github.com/repos/pydata/xarray/issues/1696 MDEyOklzc3VlQ29tbWVudDM0MzY0OTQzMQ== jhamman 2443309 2017-11-11T08:30:35Z 2017-11-11T08:30:35Z MEMBER

@MaximilianR - quick update. My implementation of ffill/bfill in #1640 is a bit cleaner now and seems to be working. It probably makes sense for me to just finish off this feature in that PR. Maybe you could give it a review when you get a chance? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ffill & bfill methods 271991268
342719382 https://github.com/pydata/xarray/pull/1696#issuecomment-342719382 https://api.github.com/repos/pydata/xarray/issues/1696 MDEyOklzc3VlQ29tbWVudDM0MjcxOTM4Mg== jhamman 2443309 2017-11-08T06:01:57Z 2017-11-08T06:01:57Z MEMBER

@MaximilianR - I have rough implementation of both of these on my interpolate branch:

https://github.com/jhamman/xarray/blob/56f37144f2dc827b61aa61f94c69277e6a79c262/xarray/core/missing.py#L206-L234

some slight modifications gives this:

```Python def _bfill(arr, n=None, axis=-1): '''inverse of ffill''' import bottleneck as bn

arr = np.flip(arr, axis=axis)

# fill
arr = bn.push(arr, axis=axis, n=n)

# reverse back to original
return np.flip(arr, axis=axis)

def ffill(self, dim=None, limit=None): ''' ''' import bottleneck as bn

return apply_ufunc(bn.push, self,
                   dask='forbidden',
                   keep_attrs=True,
                   kwargs=dict(n=limit, axis=self.get_axis_num(dim))).transpose(*arr.dims)

def bfill(self, dim=None, limit=None): ''' ''' return apply_ufunc(_bfill, self, dask='forbidden', keep_attrs=True, kwargs=dict(n=limit, axis=self.get_axis_num(dim))).transpose(*arr.dims) ```

As @shoyer says, it may be possible to change to dask='parallelized' but I have tried it yet.

Feel free to take what you want from this snippet, I am moving pretty slowly on my interpolation branch but it would be great if you can get this in as a stand alone feature.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   ffill & bfill methods 271991268
342681838 https://github.com/pydata/xarray/pull/1696#issuecomment-342681838 https://api.github.com/repos/pydata/xarray/issues/1696 MDEyOklzc3VlQ29tbWVudDM0MjY4MTgzOA== shoyer 1217238 2017-11-08T01:38:48Z 2017-11-08T01:38:48Z MEMBER

Do we prefer fillna with options (back / forward / replacement), or ffill, bfill, fillna?

I like separate methods. It keeps things logically well separated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ffill & bfill methods 271991268

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);