issue_comments

Table actions

2 rows where issue = 271017521 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 2 ✖

issue 1

  • Remove netCDF dependency from rasterio backend tests · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
341742157 https://github.com/pydata/xarray/pull/1687#issuecomment-341742157 https://api.github.com/repos/pydata/xarray/issues/1687 MDEyOklzc3VlQ29tbWVudDM0MTc0MjE1Nw== shoyer 1217238 2017-11-03T15:45:25Z 2017-11-03T15:45:25Z MEMBER

My reasoning (I guess) was that we shouldn't create Dataset objects which cannot be serialized to NetCDF (for whatever reason, for example because we store rasterio objects of some kind), since NetCDF is the preferred way to serialize xarray objects.

I agree that this is a good sanity check.

@maaleske Can we maybe move the netCDF serialization to separate tests that only do that? With the appropriate decorators, of course.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove netCDF dependency from rasterio backend tests 271017521
341737298 https://github.com/pydata/xarray/pull/1687#issuecomment-341737298 https://api.github.com/repos/pydata/xarray/issues/1687 MDEyOklzc3VlQ29tbWVudDM0MTczNzI5OA== shoyer 1217238 2017-11-03T15:30:00Z 2017-11-03T15:30:00Z MEMBER

I'm not quite sure why @fmaussion added these checks (so I will let him chime in here). I certainly agree that any tests that require writing netCDFs should have the appropriate import checks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove netCDF dependency from rasterio backend tests 271017521

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);