home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 341742157

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1687#issuecomment-341742157 https://api.github.com/repos/pydata/xarray/issues/1687 341742157 MDEyOklzc3VlQ29tbWVudDM0MTc0MjE1Nw== 1217238 2017-11-03T15:45:25Z 2017-11-03T15:45:25Z MEMBER

My reasoning (I guess) was that we shouldn't create Dataset objects which cannot be serialized to NetCDF (for whatever reason, for example because we store rasterio objects of some kind), since NetCDF is the preferred way to serialize xarray objects.

I agree that this is a good sanity check.

@maaleske Can we maybe move the netCDF serialization to separate tests that only do that? With the appropriate decorators, of course.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  271017521
Powered by Datasette · Queries took 0.993ms · About: xarray-datasette