issue_comments

Table actions

3 rows where issue = 264509098 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • Improve documentation and error validation for set_options(arithmetic_join) · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
652804739 https://github.com/pydata/xarray/issues/1624#issuecomment-652804739 https://api.github.com/repos/pydata/xarray/issues/1624 MDEyOklzc3VlQ29tbWVudDY1MjgwNDczOQ== shoyer 1217238 2020-07-02T06:10:40Z 2020-07-02T06:10:40Z MEMBER

The validation was implemented in #2261, but the docstring could still use improvement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve documentation and error validation for set_options(arithmetic_join) 264509098
409756878 https://github.com/pydata/xarray/issues/1624#issuecomment-409756878 https://api.github.com/repos/pydata/xarray/issues/1624 MDEyOklzc3VlQ29tbWVudDQwOTc1Njg3OA== shoyer 1217238 2018-08-01T23:23:18Z 2018-08-01T23:23:35Z MEMBER

@rmsare thanks for taking a crack at this!

I added some related validations as part of this larger PR, but it's still a work in progress: https://github.com/pydata/xarray/pull/2261

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve documentation and error validation for set_options(arithmetic_join) 264509098
335849507 https://github.com/pydata/xarray/issues/1624#issuecomment-335849507 https://api.github.com/repos/pydata/xarray/issues/1624 MDEyOklzc3VlQ29tbWVudDMzNTg0OTUwNw== shoyer 1217238 2017-10-11T15:27:56Z 2017-10-11T15:27:56Z MEMBER

By scanning the code I gathered that the valid values (and their meanings) should be the same as align(join=...), but I'd like confirmation on that...

That's correct. We should update the documentation and add a check.

Using enums might have been a better idea here than string values, but that's somewhat rare in scipy/pandas code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve documentation and error validation for set_options(arithmetic_join) 264509098

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);