issue_comments: 335849507

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1624#issuecomment-335849507 https://api.github.com/repos/pydata/xarray/issues/1624 335849507 MDEyOklzc3VlQ29tbWVudDMzNTg0OTUwNw== 1217238 2017-10-11T15:27:56Z 2017-10-11T15:27:56Z MEMBER

By scanning the code I gathered that the valid values (and their meanings) should be the same as align(join=...), but I'd like confirmation on that...

That's correct. We should update the documentation and add a check.

Using enums might have been a better idea here than string values, but that's somewhat rare in scipy/pandas code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   264509098