issue_comments

Table actions

3 rows where issue = 264322686 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Improved netcdf4 error message when opening non existent file · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
338302676 https://github.com/pydata/xarray/pull/1622#issuecomment-338302676 https://api.github.com/repos/pydata/xarray/issues/1622 MDEyOklzc3VlQ29tbWVudDMzODMwMjY3Ng== jhamman 2443309 2017-10-20T19:35:11Z 2017-10-20T19:35:11Z MEMBER

closed via Unidata/netcdf4-python#727

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved netcdf4 error message when opening non existent file 264322686
337351475 https://github.com/pydata/xarray/pull/1622#issuecomment-337351475 https://api.github.com/repos/pydata/xarray/issues/1622 MDEyOklzc3VlQ29tbWVudDMzNzM1MTQ3NQ== jhamman 2443309 2017-10-17T19:57:00Z 2017-10-17T19:57:00Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved netcdf4 error message when opening non existent file 264322686
335589665 https://github.com/pydata/xarray/pull/1622#issuecomment-335589665 https://api.github.com/repos/pydata/xarray/issues/1622 MDEyOklzc3VlQ29tbWVudDMzNTU4OTY2NQ== jhamman 2443309 2017-10-10T19:58:20Z 2017-10-10T19:58:20Z MEMBER

@shoyer - I think this is about as good as we can do:

Here's what's happening: - netcdf4 is raising an IOError when the file is not found: https://github.com/Unidata/netcdf4-python/blob/3da921e93f158f6e443bbb9c8bfdfe681fac4351/netCDF4/_netCDF4.pyx#L2011 - but the error number is not being passed correctly to IOError so depending if we're on python 2 or 3, it seems this gets cast to either a IOError (py2) or a OSError (py3): https://github.com/Unidata/netcdf4-python/blob/3da921e93f158f6e443bbb9c8bfdfe681fac4351/netCDF4/_netCDF4.pyx#L1631-L1634

In my last commit, I think we can just catch the IOError and reraise a IOError (looks like FileNotFoundError on python3.

This got more complicated than it need to but I'm pretty confident this works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved netcdf4 error message when opening non existent file 264322686

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);