issue_comments: 335589665

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1622#issuecomment-335589665 https://api.github.com/repos/pydata/xarray/issues/1622 335589665 MDEyOklzc3VlQ29tbWVudDMzNTU4OTY2NQ== 2443309 2017-10-10T19:58:20Z 2017-10-10T19:58:20Z MEMBER

@shoyer - I think this is about as good as we can do:

Here's what's happening: - netcdf4 is raising an IOError when the file is not found: https://github.com/Unidata/netcdf4-python/blob/3da921e93f158f6e443bbb9c8bfdfe681fac4351/netCDF4/_netCDF4.pyx#L2011 - but the error number is not being passed correctly to IOError so depending if we're on python 2 or 3, it seems this gets cast to either a IOError (py2) or a OSError (py3): https://github.com/Unidata/netcdf4-python/blob/3da921e93f158f6e443bbb9c8bfdfe681fac4351/netCDF4/_netCDF4.pyx#L1631-L1634

In my last commit, I think we can just catch the IOError and reraise a IOError (looks like FileNotFoundError on python3.

This got more complicated than it need to but I'm pretty confident this works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   264322686