issue_comments

Table actions

3 rows where issue = 256912384 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jhamman · 3 ✖

issue 1

  • support dask arrays in rolling computations using bottleneck functions · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
329535413 https://github.com/pydata/xarray/pull/1568#issuecomment-329535413 https://api.github.com/repos/pydata/xarray/issues/1568 MDEyOklzc3VlQ29tbWVudDMyOTUzNTQxMw== jhamman 2443309 2017-09-14T16:24:03Z 2017-09-14T16:24:03Z MEMBER

any final comments here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support dask arrays in rolling computations using bottleneck functions 256912384
329068071 https://github.com/pydata/xarray/pull/1568#issuecomment-329068071 https://api.github.com/repos/pydata/xarray/issues/1568 MDEyOklzc3VlQ29tbWVudDMyOTA2ODA3MQ== jhamman 2443309 2017-09-13T06:03:59Z 2017-09-13T06:03:59Z MEMBER

Can we trigger this warning lazily (e.g., when calling actually resample)? If we do this at import time we are going to get a lot of complaints from users using bottleneck < 1.1 about irrelevant warnings.

@shoyer - I'm not exactly sure how to do this consistently throughout the package. In d532a1f I removed the warning and we fall back to numpy silently. Here's some ideas of what we could do:

  1. Raise an error/warning when an unsupported version of bottleneck is imported
  2. Not check the version of bottleneck at all and live with some harder to predict behavior on rolling.meadian()
  3. Silently fall back to numpy when an unsupported version of bottleneck is imported...and for rolling methods, raise a warning at either import (easy) or runtime (harder).

I'm actually leaning toward 2 right now. We don't enforce strict minimum versions on other dependencies so it seems like what we're trying to do may be a bit overkill.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support dask arrays in rolling computations using bottleneck functions 256912384
328750128 https://github.com/pydata/xarray/pull/1568#issuecomment-328750128 https://api.github.com/repos/pydata/xarray/issues/1568 MDEyOklzc3VlQ29tbWVudDMyODc1MDEyOA== jhamman 2443309 2017-09-12T06:21:33Z 2017-09-12T06:21:33Z MEMBER

I went ahead and changed the bottleneck version. It really cleans up the all the rolling methods and the testing so I think this is an overall nice change. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   support dask arrays in rolling computations using bottleneck functions 256912384

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);