issue_comments: 329068071

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1568#issuecomment-329068071 https://api.github.com/repos/pydata/xarray/issues/1568 329068071 MDEyOklzc3VlQ29tbWVudDMyOTA2ODA3MQ== 2443309 2017-09-13T06:03:59Z 2017-09-13T06:03:59Z MEMBER

Can we trigger this warning lazily (e.g., when calling actually resample)? If we do this at import time we are going to get a lot of complaints from users using bottleneck < 1.1 about irrelevant warnings.

@shoyer - I'm not exactly sure how to do this consistently throughout the package. In d532a1f I removed the warning and we fall back to numpy silently. Here's some ideas of what we could do:

  1. Raise an error/warning when an unsupported version of bottleneck is imported
  2. Not check the version of bottleneck at all and live with some harder to predict behavior on rolling.meadian()
  3. Silently fall back to numpy when an unsupported version of bottleneck is imported...and for rolling methods, raise a warning at either import (easy) or runtime (harder).

I'm actually leaning toward 2 right now. We don't enforce strict minimum versions on other dependencies so it seems like what we're trying to do may be a bit overkill.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   256912384