issue_comments

Table actions

7 rows where issue = 255813811 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • fix unintentional skipped tests · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
334315436 https://github.com/pydata/xarray/pull/1557#issuecomment-334315436 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMzNDMxNTQzNg== shoyer 1217238 2017-10-04T23:10:44Z 2017-10-04T23:10:44Z MEMBER

LGTM, thanks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
334298058 https://github.com/pydata/xarray/pull/1557#issuecomment-334298058 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMzNDI5ODA1OA== jhamman 2443309 2017-10-04T21:41:45Z 2017-10-04T21:41:45Z MEMBER

@shoyer - ready for a final review. Turns out, we can just use the unittest decorators. Basically no changes to the test code base :). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
333583361 https://github.com/pydata/xarray/pull/1557#issuecomment-333583361 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMzMzU4MzM2MQ== shoyer 1217238 2017-10-02T16:12:22Z 2017-10-02T16:12:31Z MEMBER

Another option is to give up on class decorators and only use a method decorator -- which we could even write ourselves if necessary. We have most of us backend specific logic in a few helper functions that we override for each subclass, so we only really need to decorate those, e.g.,

``` def conditional_skip(condition, reason=''): def wrapped(args, kwargs): if condition: raise unittest.SkipTest(reason) return wrapped(args, **kwargs) return wrapped

class NetCDFSubclassTest(UnitTest): ... @contextmanager @conditional_skip(...) def roundtrip(self): ... ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
327886446 https://github.com/pydata/xarray/pull/1557#issuecomment-327886446 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMyNzg4NjQ0Ng== jhamman 2443309 2017-09-07T18:34:48Z 2017-09-07T18:34:48Z MEMBER

Maybe it's worth trying the work-around from pytest-dev/pytest#568 (comment)

This gets us quite close but doesn't allow us to have use multiple decorators at once. I'll keep digging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
327875587 https://github.com/pydata/xarray/pull/1557#issuecomment-327875587 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMyNzg3NTU4Nw== shoyer 1217238 2017-09-07T17:54:38Z 2017-09-07T17:54:38Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
327812648 https://github.com/pydata/xarray/pull/1557#issuecomment-327812648 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMyNzgxMjY0OA== jhamman 2443309 2017-09-07T14:15:00Z 2017-09-07T14:16:17Z MEMBER

What about the other @requires class decorators?

I had this thought too. We don't decorate too many classes but I image we have other issues.

I wonder if this propagation to parent classes is a feature or a bug?

I would think this is a bug. I'm working on a simplified example to report this to pytest.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811
327805477 https://github.com/pydata/xarray/pull/1557#issuecomment-327805477 https://api.github.com/repos/pydata/xarray/issues/1557 MDEyOklzc3VlQ29tbWVudDMyNzgwNTQ3Nw== fmaussion 10050469 2017-09-07T13:50:48Z 2017-09-07T13:50:48Z MEMBER

I wonder if this propagation to parent classes is a feature or a bug? Seems quite messy to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix unintentional skipped tests 255813811

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);