issue_comments: 333583361

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1557#issuecomment-333583361 https://api.github.com/repos/pydata/xarray/issues/1557 333583361 MDEyOklzc3VlQ29tbWVudDMzMzU4MzM2MQ== 1217238 2017-10-02T16:12:22Z 2017-10-02T16:12:31Z MEMBER

Another option is to give up on class decorators and only use a method decorator -- which we could even write ourselves if necessary. We have most of us backend specific logic in a few helper functions that we override for each subclass, so we only really need to decorate those, e.g.,

``` def conditional_skip(condition, reason=''): def wrapped(args, kwargs): if condition: raise unittest.SkipTest(reason) return wrapped(args, **kwargs) return wrapped

class NetCDFSubclassTest(UnitTest): ... @contextmanager @conditional_skip(...) def roundtrip(self): ... ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   255813811