issue_comments

Table actions

3 rows where issue = 252813229 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fixed issue #1520, by adding a if-else that checks for None · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
326645812 https://github.com/pydata/xarray/pull/1526#issuecomment-326645812 https://api.github.com/repos/pydata/xarray/issues/1526 MDEyOklzc3VlQ29tbWVudDMyNjY0NTgxMg== jhamman 2443309 2017-09-01T17:58:38Z 2017-09-01T17:58:38Z MEMBER

This looks good now. Failing tests are unrelated so I'm going to merge. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed issue #1520, by adding a if-else that checks for None 252813229
325572050 https://github.com/pydata/xarray/pull/1526#issuecomment-325572050 https://api.github.com/repos/pydata/xarray/issues/1526 MDEyOklzc3VlQ29tbWVudDMyNTU3MjA1MA== leeviannala 25015426 2017-08-29T06:53:20Z 2017-08-29T06:53:20Z CONTRIBUTOR

I'm getting random errors on flake8 test from whats-new.rst, but otherwise it passes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed issue #1520, by adding a if-else that checks for None 252813229
325485563 https://github.com/pydata/xarray/pull/1526#issuecomment-325485563 https://api.github.com/repos/pydata/xarray/issues/1526 MDEyOklzc3VlQ29tbWVudDMyNTQ4NTU2Mw== jhamman 2443309 2017-08-28T21:20:40Z 2017-08-28T21:20:40Z MEMBER

This looks good to me. It would be nice to have a test for this but I'm not sure its worth the effort for what is probably a rarely seen corner case.

We do need a whats-new note and to check the flake8 box. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed issue #1520, by adding a if-else that checks for None 252813229

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);